Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): publish agoric-upgrade-13 #8633

Merged
merged 51 commits into from
Dec 7, 2023

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented Dec 7, 2023

Packages that have NEWS.md updates

--- a/golang/cosmos/CHANGELOG.md
+++ b/golang/cosmos/CHANGELOG.md
@@ -3,6 +3,30 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.35.0-u13.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-12-07)
+
+
+### Features
+
+* **cosmos:** un-wire x/crisis ([#8582](https://github.com/Agoric/agoric-sdk/issues/8582)) ([19404a3](https://github.com/Agoric/agoric-sdk/commit/19404a3c5cd10d9c454f190b60cbf0aa715f605c))
+* **x/swingset:** auto-provision smart wallet ([5073800](https://github.com/Agoric/agoric-sdk/commit/5073800f87c92a194a21c9cc59ad1bb570a39b95))
+* **x/swingset:** refuse smart wallet messages if not provisioned ([50a5a55](https://github.com/Agoric/agoric-sdk/commit/50a5a557956562fc05b8c2defd99a0102a35153f))
+* pick up return-grants from latest cosmos-sdk ([975533e](https://github.com/Agoric/agoric-sdk/commit/975533e088f96c80cf8d6f6b7c5f45665e3495ba))
+* update ibc-go to v4, adapt packages and API ([6672e5c](https://github.com/Agoric/agoric-sdk/commit/6672e5cb780c8baa530ac59bff27d793e1ff8f50))
+
+
+### Bug Fixes
+
+* handle hang-on-halt behavior from agoric-labs/cosmos-sdk[#305](https://github.com/Agoric/agoric-sdk/issues/305) ([7ae9a70](https://github.com/Agoric/agoric-sdk/commit/7ae9a705478727d1d7ace7c665861cfee14b5f28))
+* update dependencies to fix tests ([9d750dd](https://github.com/Agoric/agoric-sdk/commit/9d750dd39993d380a5e889ea7faa4bb78c3257aa))
+
+
+### Reverts
+
+* Revert "fix: handle hang-on-halt behavior from agoric-labs/cosmos-sdk#305" ([3a37f5e](https://github.com/Agoric/agoric-sdk/commit/3a37f5e472405d1d3bee2075b47ecd3632ba4073)), closes [agoric-labs/cosmos-sdk#305](https://github.com/agoric-labs/cosmos-sdk/issues/305) [agoric-labs/cosmos-sdk#305](https://github.com/agoric-labs/cosmos-sdk/issues/305)
+
+
+
 ## [0.35.0-u12.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-11-10)
 
 
--- a/packages/SwingSet/CHANGELOG.md
+++ b/packages/SwingSet/CHANGELOG.md
@@ -3,6 +3,15 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+### [0.32.3-u13.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-12-07)
+
+
+### Bug Fixes
+
+* handle Node 18 breaking change ([#8600](https://github.com/Agoric/agoric-sdk/issues/8600)) ([2c64440](https://github.com/Agoric/agoric-sdk/commit/2c64440d5b5957076ad9ac7b9243de3b600c859f))
+
+
+
 ### [0.32.3-u12.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-11-10)
 
 
--- a/packages/agoric-cli/CHANGELOG.md
+++ b/packages/agoric-cli/CHANGELOG.md
@@ -3,6 +3,32 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.22.0-u13.0](https://github.com/Agoric/agoric-sdk/compare/[email protected]@0.22.0-u13.0) (2023-12-07)
+
+
+### ⚠ BREAKING CHANGES
+
+* restrict exports from 'agoric' package
+
+### Features
+
+* **cosmos:** un-wire x/crisis ([#8582](https://github.com/Agoric/agoric-sdk/issues/8582)) ([19404a3](https://github.com/Agoric/agoric-sdk/commit/19404a3c5cd10d9c454f190b60cbf0aa715f605c))
+
+
+### Bug Fixes
+
+* **agops:** fix continuing id lookup in oracle setPrice ([0ac9697](https://github.com/Agoric/agoric-sdk/commit/0ac969746c7337d45287fd040b636d27d296a062))
+* **agoric:** print errors while following ([deab7e4](https://github.com/Agoric/agoric-sdk/commit/deab7e4065fe5dd6cc1a3c5bf8c0db861cb7856b))
+* **casting:** dont crash on bad capdata ([3f01369](https://github.com/Agoric/agoric-sdk/commit/3f0136994c0b4033c872f9593cabb19bab05f01c))
+* **cli:** handle not found error in vstorage requests ([8111c43](https://github.com/Agoric/agoric-sdk/commit/8111c4344bcaa6e06085020813e2431cba9d1632))
+
+
+### Miscellaneous Chores
+
+* restrict exports from 'agoric' package ([63c1abb](https://github.com/Agoric/agoric-sdk/commit/63c1abbfcb0710bdd0a22382eb4a683216a6c453))
+
+
+
 ### [0.21.2-u12.0](https://github.com/Agoric/agoric-sdk/compare/[email protected]@0.21.2-u12.0) (2023-11-10)
 
 **Note:** Version bump only for package agoric
--- a/packages/casting/CHANGELOG.md
+++ b/packages/casting/CHANGELOG.md
@@ -3,6 +3,16 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+### [0.4.3-u13.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-12-07)
+
+
+### Bug Fixes
+
+* **casting:** dont crash on bad capdata ([3f01369](https://github.com/Agoric/agoric-sdk/commit/3f0136994c0b4033c872f9593cabb19bab05f01c))
+* **casting:** properly follow an unpopulated state entry ([48296f7](https://github.com/Agoric/agoric-sdk/commit/48296f78f783e8e5ae1e5fbe92ae10e5e7880837))
+
+
+
 ### [0.4.3-u12.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-11-10)
 
 **Note:** Version bump only for package @agoric/casting
--- a/packages/cosmic-swingset/CHANGELOG.md
+++ b/packages/cosmic-swingset/CHANGELOG.md
@@ -3,6 +3,20 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.42.0-u13.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-12-07)
+
+
+### Features
+
+* add exporter.getHostKV() API ([16435d2](https://github.com/Agoric/agoric-sdk/commit/16435d20e9ede86916a54c7bae54ecfc59e4c950)), closes [#8523](https://github.com/Agoric/agoric-sdk/issues/8523)
+
+
+### Bug Fixes
+
+* export state-sync snapshot without a DB write-lock ([2d388c2](https://github.com/Agoric/agoric-sdk/commit/2d388c2d51425b9d98b79d54ea6a2de96da67042)), closes [#8523](https://github.com/Agoric/agoric-sdk/issues/8523)
+
+
+
 ## [0.42.0-u12.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-11-10)
 
 
--- a/packages/inter-protocol/CHANGELOG.md
+++ b/packages/inter-protocol/CHANGELOG.md
@@ -3,6 +3,15 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+### [0.16.2-u13.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-12-07)
+
+
+### Bug Fixes
+
+* **inter-protocol:** brands in CLI need not start with A-Z ([#8258](https://github.com/Agoric/agoric-sdk/issues/8258)) ([fd9a44d](https://github.com/Agoric/agoric-sdk/commit/fd9a44db84e2cb9c9c78f850be7dbb8911650d54))
+
+
+
 ### [0.16.2-u12.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-11-10)
 
 **Note:** Version bump only for package @agoric/inter-protocol
--- a/packages/solo/CHANGELOG.md
+++ b/packages/solo/CHANGELOG.md
@@ -3,6 +3,15 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+### [0.10.4-u13.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-12-07)
+
+
+### Bug Fixes
+
+* **solo:** properly expose `/wallet/bridge.html` ([#8533](https://github.com/Agoric/agoric-sdk/issues/8533)) ([0095b0d](https://github.com/Agoric/agoric-sdk/commit/0095b0d8ef4cfd42e17b64f391c30eac8a5f018a))
+
+
+
 ### [0.10.4-u12.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-11-10)
 
 
--- a/packages/swing-store/CHANGELOG.md
+++ b/packages/swing-store/CHANGELOG.md
@@ -3,6 +3,15 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+### [0.9.2-u13.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-12-07)
+
+
+### Features
+
+* add exporter.getHostKV() API ([16435d2](https://github.com/Agoric/agoric-sdk/commit/16435d20e9ede86916a54c7bae54ecfc59e4c950)), closes [#8523](https://github.com/Agoric/agoric-sdk/issues/8523)
+
+
+
 ### [0.9.2-u12.0](https://github.com/Agoric/agoric-sdk/compare/@agoric/[email protected]...@agoric/[email protected]) (2023-11-10)
 
 

mhofman and others added 30 commits December 1, 2023 17:13
it's only for installing the bin and importing that bin module
refactor clientSupport to not depend on agoric-cli package
* fix(inter-protocol): brands in CLI need not start with A-Z

* test(inter-protocol): clientSupport for initial non-uppercase

* fixup! fix(inter-protocol): brands in CLI need not start with A-Z

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
The backport referenced above has the agd process hang around after halting.
Wrote a wrapper utility which scans stderr for the halt application message,
interrupts the process, then propagates its error signal. Conventional shell
scripting is not up to the challenge of expressing this behavior.
…#305"

This reverts commit efcc3b0.

We decided to roll back the problematic change (agoric-labs/cosmos-sdk#305).
feat: update ibc-go to v4, adapt packages and API
…t-found

fix(cli): handle not found error in vstorage requests
fix(casting): dont crash on bad capdata
fix(agops): fix continuing id lookup in oracle setPrice
mhofman and others added 12 commits December 6, 2023 20:07
Exporting a state-sync snapshot is a read-only operation, and is
designed to run "in the background", i.e. in parallel with normal
mutating operations. It accomplishes this by opening a read-only
transaction right away, effectively capturing a snapshot of the SQLite
database state, to insulate the export process from ongoing writes by
the execution host.

The cosmic-swingset exporter starts with a query of `host.height`, to
confirm that the database has not already advanced to a new block
before this snapshot/read-transaction can be taken.

Previously, this query worked by using `openSwingStore`, and then
calling `hostStorage.hostKVStore.get('host.height')`. This had two
problems:

* TOCTTOU: the `hostKVStore.get` used a different DB connection (and
  different txn) than the exporter, so it might return a different
  height, negating the accuracy of the consistency check

* read-write txn: `openSwingStore` creates a read-*write* txn, even
  when merely opening the DB (because it might need to create the
  initial tables). This txn is closed right away, before
  `openSwingStore()` returns, so it did not present a threat to
  ongoing operations. But if the exporter was created while the
  ongoing execution side already had its own read-write txn
  open (e.g. while `controller.run()` was running), then it would
  fail, and `makeSwingStoreExporter` would fail with `SQLITE_BUSY`

Instead, we take advantage of the new `swingStoreExporter.getHostKV()`
API, and use *it* to fetch `host.height`. Unlike the normal
swingstore, the swingstore-exporter refrains from creating read-write
transactions entirely. So the cosmic-swingset export code can safely
query the height without fear of getting the wrong value or failing
because of an ongoing write transaction.

We think this should fix the SQLITE_BUSY errors.

refs #8523
…lock

fix: export state-sync snapshot without a DB write-lock
feat: allow clawback vesting accounts to return grants
* feat(cosmos): un-wire x/crisis

* fixup! feat(cosmos): un-wire x/crisis

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@mhofman mhofman requested a review from toliaqat December 7, 2023 02:10
@mhofman
Copy link
Member Author

mhofman commented Dec 7, 2023

The release commit is be59032, rest comes from previous dev-upgrade-13 branch PRs.

@mhofman mhofman added the force:integration Force integration tests to run on PR label Dec 7, 2023
Copy link
Contributor

@toliaqat toliaqat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.
Left couple of comments and wanted you to double if we need to update the following file?

packages/xsnap/package.json

https://github.com/Agoric/agoric-sdk/blob/prepare-release-20231207T020132/packages/xsnap/package.json#L31

@@ -24,7 +14,7 @@ By default pre-releases use the lastest image tagged `dev` in our [container rep
a specific build:

```shell
DEST_IMAGE=docker pull ghcr.io/agoric/agoric-sdk:20230515033839-e56ae7
DEST_IMAGE=ghcr.io/agoric/agoric-sdk:20230515033839-e56ae7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change this tag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just an example in the readme

// upgrade12Handler performs standard upgrade actions plus custom actions for upgrade-12.
func upgrade12Handler(app *GaiaApp, targetUpgrade string) func(sdk.Context, upgradetypes.Plan, module.VersionMap) (module.VersionMap, error) {
// upgrade13Handler performs standard upgrade actions plus custom actions for upgrade-13.
func upgrade13Handler(app *GaiaApp, targetUpgrade string) func(sdk.Context, upgradetypes.Plan, module.VersionMap) (module.VersionMap, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is nothing specific in this function, should we rename it to just upgradeHandler?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how we've been managing upgrade handlers. This change is coming from #8588 which prepared the upgrade-13 branch

@@ -43,4 +43,4 @@ run_test:
shell:
docker exec -it `docker ps --latest --format json | jq -r .Names` bash

.PHONY: local_sdk agoric-upgrade-7-2 agoric-upgrade-8 agoric-upgrade-8-1 agoric-upgrade-9 agoric-upgrade-10 agoric-upgrade-11 agoric-upgrade-12 build build_test run
.PHONY: local_sdk agoric-upgrade-13 build build_test run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we not need to run all the upgrades like before?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because those are now part of agoric-3-proposals. This was some cleanup done in #8588

Copy link
Contributor

@toliaqat toliaqat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhofman I am conditionally approving this PR. Please check if you need to update version numbers in the following file before merging this PR.

https://github.com/Agoric/agoric-sdk/blob/prepare-release-20231207T020132/packages/xsnap/package.json

@mhofman
Copy link
Member Author

mhofman commented Dec 7, 2023

@mhofman I am conditionally approving this PR. Please check if you need to update version numbers in the following file before merging this PR.

https://github.com/Agoric/agoric-sdk/blob/prepare-release-20231207T020132/packages/xsnap/package.json

Oh I see what you mean. The xsnap-lockdown version didn't get bumped, and arguably it should to represent the fact the bundle on chain is now different. I'll see what I can do.

@mhofman mhofman force-pushed the prepare-release-20231207T020132 branch from be59032 to 5a6cdeb Compare December 7, 2023 14:58
@mhofman
Copy link
Member Author

mhofman commented Dec 7, 2023

@toliaqat I forced a version bump on xsnap-lockdown, triggering a bump on xsnap as well.
I also included the fix from #8527 (which is still pending review...) since the tag tool is currently broken

Overall diff since reviewed: be59032..5a6cdeb

PTAL

@mhofman mhofman requested a review from toliaqat December 7, 2023 15:07
@toliaqat
Copy link
Contributor

toliaqat commented Dec 7, 2023

@mhofman thank you.

I think because of the broken tool, we missed u11wf.0 tag updates in the past as well.
Can you check if we need to update them for @agoric/assert and @agoric/access-token pacakges.
https://github.com/Agoric/agoric-sdk/blob/prepare-release-20231207T020132/packages/agoric-cli/package.json#L37

And update version in eslint-config
https://github.com/Agoric/agoric-sdk/blob/prepare-release-20231207T020132/packages/eslint-config/package.json#L3

@mhofman
Copy link
Member Author

mhofman commented Dec 7, 2023

I think because of the broken tool, we missed u11wf.0 tag updates in the past as well.

To be clear, it's totally normal for packages that didn't experience any changes to not get their version bumped. In the case of xsnap-lockdown it actually was a problem because we patched ses resulting in a different content of the distributed bundle. I don't think it was your intent to point this specific issue out, but your review made me realize the problem, which I've addressed for that package specifically.

The other packages can stay without a version change.

@toliaqat
Copy link
Contributor

toliaqat commented Dec 7, 2023

🚀

@mhofman mhofman merged commit b0c1f78 into release-mainnet1B Dec 7, 2023
60 checks passed
@mhofman mhofman deleted the prepare-release-20231207T020132 branch December 7, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants